-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: improve getCurrentStyle type #363
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR improves the type definition of the Class diagram showing the type improvement for getCurrentStyleclassDiagram
class Vue3Marquee {
-getCurrentStyle: ComputedRef<Record<string, string>>
+cssVariables: Record<string, string>
+animationStyles: Record<string, string>
}
note for Vue3Marquee "Type changed from 'any' to
ComputedRef<Record<string, string>>"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chouchouji - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Enhancements:
getCurrentStyle
asComputedRef<Record<string, string>>
for better type safety.Issue
close #361