-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for LayerGroups #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @hblitza. Looks very good. Please refer to the comments in the review and please also ensure that you add at least a test for each function.
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Thx for review! |
Thanks for your ongoing work @hblitza. As stated in my review, please add at least one test for each function before we can merge this. |
Right, I will add a |
@chrismayer please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your ongoing work @hblitza. Looks good to me now. 2 minor comments you might want to have a look at before merging.
Right, thanks! |
Thanks for your ongoing work @hblitza. I am going to merge now. |
This adds a class
LayerGroupClient
and initiates it with aget
andmodify
method.@chrismayer please check