Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for LayerGroups #137

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Conversation

hblitza
Copy link
Contributor

@hblitza hblitza commented Oct 23, 2023

This adds a class LayerGroupClient and initiates it with a get and modify method.

@chrismayer please check

Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @hblitza. Looks very good. Please refer to the comments in the review and please also ensure that you add at least a test for each function.

src/layergroup.js Outdated Show resolved Hide resolved
src/layergroup.js Outdated Show resolved Hide resolved
src/layergroup.js Outdated Show resolved Hide resolved
src/layergroup.js Outdated Show resolved Hide resolved
hblitza and others added 4 commits November 2, 2023 15:04
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Co-authored-by: Christian Mayer <chris@meggsimum.de>
Co-authored-by: Christian Mayer <chris@meggsimum.de>
@hblitza
Copy link
Contributor Author

hblitza commented Nov 2, 2023

Thx for review!

@chrismayer
Copy link
Collaborator

Thanks for your ongoing work @hblitza. As stated in my review, please add at least one test for each function before we can merge this.

@hblitza
Copy link
Contributor Author

hblitza commented Nov 6, 2023

Right, I will add a create layergroup method. while working on the tests, it became clear, we need one for testing...

@hblitza
Copy link
Contributor Author

hblitza commented Nov 13, 2023

@chrismayer please check again.

Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your ongoing work @hblitza. Looks good to me now. 2 minor comments you might want to have a look at before merging.

src/layergroup.js Outdated Show resolved Hide resolved
src/layergroup.js Show resolved Hide resolved
@hblitza
Copy link
Contributor Author

hblitza commented Nov 15, 2023

Right, thanks!

@chrismayer
Copy link
Collaborator

Thanks for your ongoing work @hblitza. I am going to merge now.

@chrismayer chrismayer merged commit 3523258 into meggsimum:master Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants