After changing language, next login makes entire screen black

[lucasoares]

Priority

Medium

Area

• Data
• Source
• Docker
• Other

What happened?

I changed the language and when I logged into a server, the entire screen was black. I had to reopen OTClient to use it:

No errors in the console:

What OS are you seeing the problem on?

Windows

• Used the OTClient on the main branch

Code of Conduct

• I agree to follow this project's Code of Conduct

[InnerCircleTFS]

https://github.com/mehah/otclient/blob/main/modules/client_locales/locales.lua#L64

the problem is g_modules.reloadModules().
when they added the new tibia 13 layout.
they didn't care about reload all modules with g_modules.reloadModules() (onInit(), onGameStart() ), (it is rarely used. )

[lucasoares]

https://github.com/mehah/otclient/blob/main/modules/client_locales/locales.lua#L64

the problem is g_modules.reloadModules(). when they added the new tibia 13 layout. they didn't care about reload all modules with g_modules.reloadModules() (onInit(), onGameStart() ), (it is rarely used. )

I think this may be affecting other systems:

• Updater
• Auto reload (many modules doesn't reloads after editing files)

[kokekanon]

about your comment

I think this may be affecting other systems:

• Updater

Could you provide an example of how to reproduce the update error when executing g_modules.reloadModules()(updater.lua#L164)?

I was testing and updater works with init.lua, modules.lua/.otui, spr/dat . The only thing that didn't work was that it didn't reload the textures(example updating background.png).

I got it to work by adding this g_textures.clearCache() here:

https://github.com/mehah/otclient/blob/main/modules/updater/updater.lua#L164

about sound:

And yes , the music is activated, but the settings in client_options are read correctly
I guess it's a problem of g_sounds, not client_options

about this issues

I noticed that if you use g_modules.reloadModules() before logging in, it works correctly(update behavior), but if you login and then exec g_modules.reloadModules() whether logged in or not, the screen turns black.

I'm assuming it's a cpp issue because I placed the current .exe in data/modules of release 3.5, and I also get a black screen.
it must be something inside game_interface, because if I make reloadable :false in interface.otmod. in online ,g_modules.reloadModules() works correctly.

[lucasoares]

about your comment

I think this may be affecting other systems:

• Updater

Could you provide an example of how to reproduce the update error when executing g_modules.reloadModules()

I see.. I will add this information about g_textures.clearCache() on the correct issue (#1044). Thanks for that.

I'm testing it more to know which modules don't reload correctly. I think this issue (#1032) must focus on fixing the reload system to ensure the screen is not black after changing the language. For now, in my own version, I changed to always restart the client after changing the language (sad fix).

About the updater, let's focus first on the sound system being enabled after enabling the updater on its own issue (#1043). I will rename it.

Any other modules with problems using updater, I will create a new issue for it individually, so we can be more productive.

Thanks.