Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Task Module #457

Merged
merged 1 commit into from
Mar 5, 2023
Merged

feat: Task Module #457

merged 1 commit into from
Mar 5, 2023

Conversation

dewral
Copy link
Contributor

@dewral dewral commented Mar 3, 2023

Free task module made by @rookgaard
A little edited by @Tofame

https://i.imgur.com/q6xTZHS.png

@mehah
Copy link
Owner

mehah commented Mar 4, 2023

this module was developed from otv8, have you tested this client? thx

@dewral
Copy link
Contributor Author

dewral commented Mar 4, 2023

this model was developed from otv8, have you tested this client? thx

Tbh no, @Tofame was using this on mehah so i suppose it's working.
Ask him better cus not sure if there was any changes needed

@kokekanon
Copy link
Collaborator

I quickly tested
From an OTC mehah point of view IT DOES work

from TFS point of view,
Test in nekiro 1.5

I'm not sure but I have the impression that:

once you finish a task you can repeat it,
the tasks only gives experience.
"itemRewards = {}" not implemented
but I suppose that everyone can improve it to their liking from their server

but that is a separate topic, is problem of tfs and not of otc

@dewral
Copy link
Contributor Author

dewral commented Mar 4, 2023

I quickly tested

From an OTC mehah point of view IT DOES work

from TFS point of view,

Test in nekiro 1.5

I'm not sure but I have the impression that:

once you finish a task you can repeat it,

the tasks only gives experience.

"itemRewards = {}" not implemented

but I suppose that everyone can improve it to their liking from their server

but that is a separate topic, is problem of tfs and not of otc

The item reward was changed for task points as far as i remember. I think i didnt add the code to handle that

@mehah mehah merged commit d332f16 into mehah:main Mar 5, 2023
mehah added a commit that referenced this pull request Mar 5, 2023
This reverts commit d332f16.
@mehah mehah changed the title Task Module feat: task Module Mar 10, 2023
@mehah mehah changed the title feat: task Module feat: Task Module Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants