Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android sound crash #461

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix: android sound crash #461

merged 1 commit into from
Mar 7, 2023

Conversation

tuliomagalhaes
Copy link
Collaborator

Description

The OpenAL library was crashing on arm processors, then I had to update the Android's library pack and fix the build.

Behaviour

Actual

Android is crashing on arm processors

Expected

Don't crash.

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah merged commit 7d3c024 into main Mar 7, 2023
@mehah mehah deleted the fix-android-sound-crash branch March 7, 2023 18:57
@beats-dh beats-dh restored the fix-android-sound-crash branch March 10, 2023 00:52
@beats-dh beats-dh deleted the fix-android-sound-crash branch March 10, 2023 00:53
@mehah mehah changed the title Fix android sound crash fix: android sound crash Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants