improve: remove tinyxml and add pugixml instead #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehah
approved these changes
Apr 28, 2023
|
🙏 just noticed this and thanks, pugixml is much better than tinyxml |
dudantas
added a commit
that referenced
this pull request
Nov 17, 2023
Resolves #517 Resolves #520 Resolves #538 Global sync pr: https://github.com/opentibiabr/otservbr-global/pull/797/files Changed max market offer price from uint32_t to uint64_t (from 999999999 to 999999999999 client limitation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added vcpkg library pugixml in place of tinyxml, which is manual and old. pugixml is an advanced library and is now installed via vcpkg.