Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android initialization crash #554

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

tuliomagalhaes
Copy link
Collaborator

@tuliomagalhaes tuliomagalhaes commented Jun 17, 2023

Description

Android is always crashing because data.zip is not unziped before discoverWorkDir is called.

Behaviour

Actual

Unzip data.zip is called after discoverWorkDir.

Expected

Unzip data.zip should be called before discoverWorkDir.

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah changed the title Fix android initialization crash fix: android initialization crash Jun 17, 2023
@mehah mehah merged commit b27e5c1 into main Jun 18, 2023
@mehah mehah deleted the fix-android-initialization-crash branch June 18, 2023 14:28
dudantas pushed a commit that referenced this pull request Nov 17, 2023
Updated actions to work with new GHA features, preventing future builds from breaking because they are outdated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants