Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Opacity effect and missile in options #676

Merged
merged 8 commits into from
Dec 13, 2023
Merged

feat: Opacity effect and missile in options #676

merged 8 commits into from
Dec 13, 2023

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Dec 10, 2023

issue of "roriscrave" in otland https://otland.net/threads/need-otc-programmer-50u.287225/

PS: First time I make a PR

PS2: I don't know much about cpp, gesior gave the solution,
image

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

ddd

  • Test A

Test Configuration:

  • Server Version: 8.6
  • Client: Main mehah
  • Operating System: win10 x64

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
bandicam.2023-12-13.14-52-26-382.mp4

issue of "roriscrave" in otland
@gesior
Copy link
Contributor

gesior commented Dec 11, 2023

I think it should be setEffectAlpha, not setAlphaEffect to follow OTC naming convention - same for Missile.
I will commit 'tmpColor optimisation' in few days. I don't have access to PC now.

OTC naming convention
@conde2 conde2 self-requested a review December 11, 2023 16:51
src/client/effect.cpp Outdated Show resolved Hide resolved
src/client/missile.cpp Outdated Show resolved Hide resolved
src/framework/core/graphicalapplication.h Outdated Show resolved Hide resolved
@csantbr csantbr self-requested a review December 13, 2023 13:57
Copy link
Collaborator

@csantbr csantbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest keeping the OTUI spacing standard.

kokekanon and others added 3 commits December 13, 2023 11:05
Co-authored-by: Caio Santoro dos Santos <61211407+csantbr@users.noreply.github.com>
@conde2 conde2 requested review from csantbr and conde2 December 13, 2023 17:48
@conde2 conde2 marked this pull request as ready for review December 13, 2023 17:49
@conde2 conde2 removed the request for review from csantbr December 13, 2023 17:49
@conde2
Copy link
Collaborator

conde2 commented Dec 13, 2023

@csantbr this pull request can be approve, as soon as you approve it I will merge to main branch.

@conde2 conde2 dismissed csantbr’s stale review December 13, 2023 18:20

All good now. Thanks for the review =)

@conde2 conde2 merged commit 295db73 into mehah:main Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants