Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: market browsing broken in pre-12.51 protocols #746

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: market browsing broken in pre-12.51 protocols #746

merged 1 commit into from
May 3, 2024

Conversation

glecko
Copy link
Contributor

@glecko glecko commented Apr 23, 2024

Description

Since 30b6702 any market browse messages by the client in protocols prior to 12.51 that have market enabled have been missing the header. This causes the server to interpret the item ID as the header, causing all kinds of wonky behavior depending on what the item ID is.

Behavior

Actual

If you attempt to browse a market item in a 9.x / 10.x / 11.x game server, the items info is not returned. Instead, depending on which item has been browsed, a variety of things can happen (you get disconnected, you walk in a direction, nothing at all).

Expected

Attempting to browse a market item in a 9.x / 10.x / 11.x game server should return the items information.

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Server Version: 10.7
  • Client: 10.7
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah merged commit 7d96402 into mehah:main May 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants