Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Blessings #825

Closed
wants to merge 17 commits into from
Closed

feat: Blessings #825

wants to merge 17 commits into from

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Jul 21, 2024

Description

controller + css/html

bless

image

I know there are some visual errors, like

  • the close and history buttons are on the left.
  • the title of the mini windows is not visible (maybe error system html? or me error syntax?)
  • the images are probably out of order
  • windows does not appear in the middle (maybe error system html ? self:loadHtml() )
  • verticalScroll bar in historial panel

if it was otui, I would fix it but I'm not good at css /html
image
image

im 8.6 player. I don't know how it works. just wanted to test the new functionality, the module was easy to make

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

modules/game_blessing/style.otui Show resolved Hide resolved
modules/game_blessing/blessing.lua Show resolved Hide resolved
modules/game_blessing/blessing.html Show resolved Hide resolved
modules/game_blessing/blessing.lua Outdated Show resolved Hide resolved
src/client/game.h Show resolved Hide resolved
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
@kokekanon kokekanon marked this pull request as draft August 1, 2024 00:54
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
modules/game_blessing/blessing.lua Outdated Show resolved Hide resolved
modules/game_blessing/blessing.lua Outdated Show resolved Hide resolved
kokekanon and others added 5 commits August 8, 2024 17:30
@Nottinghster Nottinghster marked this pull request as ready for review August 12, 2024 17:57
@kokekanon kokekanon closed this Aug 12, 2024
@kokekanon
Copy link
Collaborator Author

kokekanon commented Aug 13, 2024

need to make a git reset --hard hash sorry open other pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants