Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vips Groups | fix issue: #730 #908

Merged
merged 13 commits into from
Oct 6, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Oct 6, 2024

test in:

Description

In simple tests it works, I do not rule out future corrections if someone finds any bugs.

image
image
image

image

I changed it to controller to facilitate reload

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

#730 26 March 2024

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

onVipStateChange offline , online
onAddVip
create , edit , remove grupos
Edit , remove, add player

Test Configuration:

  • Server Version: 860 and 1340
  • Client: this pr
  • Operating System: windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

I updated the readme, if you want I will do it in another pr. but it is not a big change.

@kokekanon kokekanon changed the title feat: Vips Groups fix | issue: #730 feat: Vips Groups | fix issue: #730 Oct 6, 2024
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
src/client/game.cpp Show resolved Hide resolved
modules/game_viplist/viplist.lua Outdated Show resolved Hide resolved
kokekanon and others added 5 commits October 6, 2024 02:10
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon kokekanon marked this pull request as draft October 6, 2024 05:19
@kokekanon kokekanon marked this pull request as ready for review October 6, 2024 05:34
@luanluciano93 luanluciano93 merged commit 205e80b into mehah:main Oct 6, 2024
10 checks passed
jordanhoare added a commit to tibia-oce/otclient that referenced this pull request Oct 11, 2024
* perf: Drawpool 3.1

more stability in FPS

* setting m_effectAlpha, m_missileAlpha to 1.f

* fix: display density on mapview

* feat: hud scale

* fix: Interface Anchors (mehah#862)

* feat: support directx

* improve: use egl v3

* small change in gc

* fix: memory leak in controller

* improve: organization of the project structure

* add new config to draw covered things

There are projects where this system doesn't work very well, so if your project is one of those, just set it to true to fix the tiles that aren't being drawn.

* feat: update background image and startup sound to use 13.40 cip files. Adjustments in options buttons order and logout button icon. (mehah#865)

* update UIGraph (need test)

* fix shader warning

* fix: console error due to shaders

* draw-covered-things to false

Note: Setting false will not draw objects that the client understands are covered. If for some reason a tile is not being drawn because your game is custom, set this property to true and this issue will be resolved.

* baseline updated (update your vcpkg)

git pull

* Revert "baseline updated (update your vcpkg)"

This reverts commit 8dda995.

* fix: mehah#867

* feat: extractTexture in framebuffer, Arch SS2 by default and cleanup

* fix: inverted texture in extractTexture

* html: support tag img

* perf: reducing locking, thus increasing performance a little.

* fix draw shader

* prevent crash in static text

* improve: add lua call protection

* perf: improve propagateOnMouseMove

* fix: bot item ondrop and analyzer loot channel (mehah#887)

* fix: outfit size , prevent ERROR: invalid thing (mehah#884)

Co-authored-by: Rodrigo Paixão <god.rodrigo@hotmail.com>

* improve: HTTP login error handling to display login.php error messages (mehah#886)

* fix: compilation error on some pcs

* feat: full cyclopedia module (mehah#868)

* fix: game_store bugs. fix: mehah#873 (mehah#874)

* feat: Minimap GM teleport ( ctrl +shift + click on minimap) (mehah#885)

Co-authored-by: Luan Luciano <luanluciano@outlook.com>

* support "Mage" vocation (mehah#882)

several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED.

Without this fix, on those servers, vBot would constantly error out with Error: (...) concatenat voc: a nil value

* fix (mehah#900)

* improve parseOpenContainer and fix error with decoration kit (mehah#890)

* fix: optional display rarity colors in items . feature GameColorizedLootValue 12.00 (mehah#896)

* fix: crash getItems (mehah#892)

* looting blacklist (mehah#881)

When "loot every item" is off, it will loot everything in the loot list.

When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on.

* Fix black and red squares behaviors (mehah#902)


* Fix squares:
- Set black squares color to 1 instead of 0 so it's not treated as alpha
- Fix creaturesMark logic so red squares don't disappear when attacking and black squares show when attacked

* feat: display tier UI (GameThingUpgradeClassification) (mehah#895)

* feat: Vips Groups | fix issue: mehah#730 (mehah#908)

* fix: spacing for align bottom vertical layouts (mehah#909)

* Fix: mehah#901

---------

Co-authored-by: Renato Machado <mehahx@gmail.com>
Co-authored-by: SkullzOTS <86809689+SkullzOTS@users.noreply.github.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Felipe Muniz <felipe.silva@virtus.ufcg.edu.br>
Co-authored-by: Rodrigo Paixão <god.rodrigo@hotmail.com>
Co-authored-by: kokekanon <114332266+kokekanon@users.noreply.github.com>
Co-authored-by: divinity76 <divinity76@gmail.com>
Co-authored-by: divinity76 <hans@loltek.net>
Co-authored-by: OT Archive <112215823+OTArchive@users.noreply.github.com>
Co-authored-by: Marcin Jałocha <nekiro.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants