Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: smooth walk #924

Merged
merged 10 commits into from
Oct 15, 2024
Merged

improve: smooth walk #924

merged 10 commits into from
Oct 15, 2024

Conversation

mehah
Copy link
Owner

@mehah mehah commented Oct 14, 2024

No description provided.

@mehah mehah changed the title improve improve: smooth camera Oct 14, 2024
@nekiro
Copy link
Collaborator

nekiro commented Oct 14, 2024

Seems that the walking broke, sometimes I can take few diagonal steps in a row, sometimes my character stops when taking turns for more time than he should. The issue with rendering from #918 still happens too.

@mehah
Copy link
Owner Author

mehah commented Oct 14, 2024

@nekiro
test again, now I think it's good, if it's shaking, it will be very little compared to the old one.

note: I tested with 1098 and 1340, vsync with 144hz and no-vsync without limited fps
unfortunately I don't have an environment with server 772 and 860.

@mehah mehah changed the title improve: smooth camera improve: smooth walk Oct 14, 2024
@nekiro
Copy link
Collaborator

nekiro commented Oct 14, 2024

@nekiro test again, now I think it's good, if it's shaking, it will be very little compared to the old one.

note: I tested with 1098 and 1340, vsync with 144hz and no-vsync without limited fps unfortunately I don't have an environment with server 772 and 860.

Now the walk lags when turning, diagonals seem to be ok.
About the shaking, no change, you can see it best with antialiasing set to none. You can still see items twitching on screen when you walk.
Also map click seems to be kinda teleporting now.
I think it's a painter issue, not the step duration/walk calculation

@mehah
Copy link
Owner Author

mehah commented Oct 15, 2024

@nekiro,

Try out the walk, I think it's better than what you'll find in the main branch.

About the shaking, I could only reproduce it by manually limiting the FPS, it doesn't happen with vsync.

Since I rewrote a lot of things, I just need you to confirm that it's working as expected. We'll try to resolve this in another PR.

@nekiro
Copy link
Collaborator

nekiro commented Oct 15, 2024

Arrow walking seems ok, map click still "teleports" and there is weird lag after first step

hexadia-client_gl_x64_89zMGPBToD.mp4

@mehah
Copy link
Owner Author

mehah commented Oct 15, 2024

@nekiro
what is your protocol? I can't reproduce this "teleport".

OTClient.-.Redemption.2024-10-15.16-01-09.mp4

try again, maybe I fixed it without realizing it.

Copy link
Collaborator

@nekiro nekiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, its working fine, it seems it was my bad with the step duration calculation (I got some custom changes and it conflicted)

@Nottinghster Nottinghster merged commit 5f61b5e into main Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants