Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packets cyclopedia 13.10 (Balance + BosstiaryInfo) #986

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Dec 10, 2024

i test PR # 4868 "Features from protocol 12+"(Dic 8, 2024) tfs generates packet error in cyclopedia

these changes do not break canary 13.40

Description

image
image image

Behavior

Actual

Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1310)
ERROR: ProtocolGame parse message exception (1242 bytes, 257 unread, last opcode is 0x00 (0), prev opcode is 0xee (238)): unhandled opcode 0
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1310)
ERROR: ProtocolGame parse message exception (2068 bytes, 2 unread, last opcode is 0x73 (115), prev opcode is 0x61 (97)): InputMessage eof reached

Expected

Do this and that happens

Fixes

otland/forgottenserver#4868

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

open cyclopedia

Test Configuration:

  • Server Version:13.10 tfs / 13.40 canary
  • Client: this pr
  • Operating System: win

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants