Add setter for setting config value once #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
pushed a commit
to science-computing/butido
that referenced
this pull request
Mar 10, 2021
This patch rewrites patch post-processing with a new setter in the config-rs
crate:
Config::set_once()
That is introduced on a PR I've written for the crate.
The PR: rust-cli/config-rs#172
The new function is more likely to land on the config-rs master branch than the
old one, as it does not introduce more exported types from the config-rs crate.
Signed-off-by: Matthias Beyer <matthias.beyer@atos.net>
Tested-by: Matthias Beyer <matthias.beyer@atos.net>
|
This is merged in config-rs-maint as of master 05b04b8a9982154b1f0755c0b4e0eb2cb3d88235. |
matthiasbeyer
force-pushed
the
add-setter
branch
from
fac5911 to
d6f0734
Compare
|
Waiting for #175 |
…::merge() overwrite it later Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
add-setter
branch
from
d6f0734 to
6ab07dd
Compare
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #165 .
I was able to implement the functionality I've described in #163 using this function (fixup of relative pathes during loading of configuration data) with this PR.
The advantage of this PR over #165 is that this PR does not need to export internal types, thus it is better than #165.