Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace travis with github actions #175

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Replace travis with github actions #175

merged 4 commits into from
Mar 17, 2021

Conversation

matthiasbeyer
Copy link
Member

No description provided.

@matthiasbeyer
Remove travis
99db671 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Add github-actions workflow
10c466f 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Member Author

Can someone tell me why this does not run through actions here?

@matthiasbeyer
Copy link
Member Author

I don't know why this runs only on my fork: https://github.com/matthiasbeyer/config-rs/actions/workflows/msrv.yml

@matthiasbeyer
Clippy: Remove manual implementation of map
39d7281 
Because clippy complains on nightly.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Fix clippy: Use is_empty() instead of comparing to empty string
b3f9a09 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Member Author

So this should succeed now: https://github.com/matthiasbeyer/config-rs/actions/runs/656871816

@matthiasbeyer
Copy link
Member Author

matthiasbeyer commented Mar 16, 2021 •
edited
Loading

I nobody objects, I will merge this after 17th March 11:00:00 UTC.
I hope the actions are then picked up for this repository.

This was referenced Mar 16, 2021
Merged
Merged
@matthiasbeyer matthiasbeyer mentioned this pull request Mar 17, 2021
Merged
@matthiasbeyer matthiasbeyer merged commit a9ce652 into rust-cli:master Mar 17, 2021
@matthiasbeyer matthiasbeyer deleted the actions branch March 17, 2021 16:32
@matthiasbeyer matthiasbeyer mentioned this pull request Mar 17, 2021
Closed
This was referenced Mar 17, 2021
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
This was referenced Mar 18, 2021
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawid-nowak dawid-nowak Awaiting requested review from dawid-nowak

@ignatenkobrain ignatenkobrain Awaiting requested review from ignatenkobrain

@joelgallant joelgallant Awaiting requested review from joelgallant

@LukeMathWalker LukeMathWalker Awaiting requested review from LukeMathWalker

@vmalloc vmalloc Awaiting requested review from vmalloc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthiasbeyer