Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require importlib-metadata #150

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

talonchandler
Copy link
Collaborator

#149 was introduced by #127, and this fixes the issue.

This error snuck by my review because I assumed importlib_metadata was a builtin. My bad. I'm surprised this snuck by our tests...I will look closer tomorrow morning and update the tests to catch.

I tested a successful install by hand. Ready to merge from my perspective.

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 23, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/150
Updated: 2022-08-23T02:54:25.405956

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@845f304). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage        ?   10.42%           
=======================================
  Files           ?       47           
  Lines           ?     5954           
  Branches        ?        0           
=======================================
  Hits            ?      621           
  Misses          ?     5333           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@talonchandler
Copy link
Collaborator Author

I've added a simple smoke test to prevent this from happening again. Tests failed on the branch from main and now pass after merging into this branch.

Ready for review + merge.

@talonchandler talonchandler linked an issue Aug 23, 2022 that may be closed by this pull request
@mattersoflight mattersoflight self-requested a review August 23, 2022 03:49
@talonchandler talonchandler merged commit ff63501 into main Sep 9, 2022
@talonchandler talonchandler deleted the require-importlib-metadata branch September 9, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Fails to run on Windows
2 participants