CLI regression fix and end-to-end CLI test #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 11.14% 11.19% +0.05%
==========================================
Files 44 44
Lines 5969 5974 +5
==========================================
+ Hits 665 669 +4
- Misses 5304 5305 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Preview page for your plugin is ready here: |
|
The fix is working and the tests are passing on all platforms. Ready for review + merge. |
talonchandler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally introduced a regression that broke the CLI in #133 (I failed to move
import osinto the new file).This PR fixes the regression and adds a test that runs the CLI in a background process and checks if it finishes successfully. This type of end-to-end test will give us more confidence that the CLI can run at all. Even though we were unit testing the functions underlying the CLI calls, the CLI was unusable and this bug made it past the tests.