Mismatched x/y size of background and acquisition should error instead of warn #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 11.20% 11.21%
=======================================
Files 45 45
Lines 5987 5985 -2
=======================================
Hits 671 671
+ Misses 5316 5314 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Preview page for your plugin is ready here: |
ziw-liu
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improvement on #181 given a discussion @ziw-liu and I had about errors vs. warnings.
Since
recOrdercan't recover from mismatched background and acquisition sizes, I have changed this warning to an error. This has the added benefit of making the error message appear to the user directly, instead of the old behavior where we received a downstream numpy error and a less visible warning.