Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in calibration_metadata writer #212

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

ieivanov
Copy link
Contributor

Changing V_min and V_max to float as QLIPP_Calibration.write_metadata fails to write json metadata if integer voltage is passed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #212 (68a21b7) into main (1a37173) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   11.02%   11.02%           
=======================================
  Files          45       45           
  Lines        6087     6087           
=======================================
  Hits          671      671           
  Misses       5416     5416           
Impacted Files Coverage Δ
recOrder/calib/Calibration.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/212
Created: 2022-09-30T18:14:44.184700

Copy link
Contributor

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ieivanov ieivanov merged commit b99c40b into main Sep 30, 2022
@ieivanov ieivanov deleted the bugfix-calibration_metadata branch September 30, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants