Recommend MM 2022-09-20 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 10.23% 10.23%
=======================================
Files 38 38
Lines 5160 5160
=======================================
Hits 528 528
Misses 4632 4632
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Preview page for your plugin is ready here: |
mattersoflight
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
Thanks @talonchandler. The two builds are within a month - the chance of a hiccup is communication between MM and pycro-manager is negligible. We run into incompatibilty when the MM device adapter API or the zeromq versions change.
ziw-liu
approved these changes
Oct 1, 2022
|
Quick note - 2022-09-20 supports writing to NDTiff! That doesn't matter here, but it's a cool feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #141 @ieivanov requested an slightly newer version of MM so that a recent change to a device driver was included.
I tested
recOrderwith 2022-09-20 and all acquisition functionality is working.pycromanagerdid not require an upgrade.This PR updates the docs and warning messages only.