Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove microscope parameters from calibration metadata #227

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented Oct 5, 2022

Resolves #224.

@ziw-liu ziw-liu added the enhancement New feature or request label Oct 5, 2022
@ziw-liu ziw-liu added this to the 0.2.0 milestone Oct 5, 2022
@ziw-liu ziw-liu self-assigned this Oct 5, 2022
@ziw-liu ziw-liu linked an issue Oct 5, 2022 that may be closed by this pull request
@ziw-liu ziw-liu marked this pull request as ready for review October 5, 2022 21:25
@ziw-liu ziw-liu requested a review from ieivanov October 5, 2022 21:25
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Oct 5, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/227
Updated: 2022-10-05T21:51:01.024960

@ziw-liu
Copy link
Contributor Author

ziw-liu commented Oct 5, 2022

One thing to notice is that these lines used to automatically update the fields in the Acq/Rec tab after loading a calibration:

# Update the Microscope Parameters with those from the previous calibration (if they're present)
params = metadata.Microscope_parameters
if params is not None:
self.ui.le_n_media.setText(str(params['n_objective_media']) if params['n_objective_media'] is not None else '')
self.ui.le_obj_na.setText(str(params['objective_NA']) if params['objective_NA'] is not None else '')
self.ui.le_cond_na.setText(str(params['condenser_NA']) if params['condenser_NA'] is not None else '')
self.ui.le_mag.setText(str(params['magnification']) if params['magnification'] is not None else '')
self.ui.le_ps.setText(str(params['pixel_size']) if params['pixel_size'] is not None else '')

Any workflow relying on this behavior will be affected.

@talonchandler
Copy link
Collaborator

Thanks Ziwen...this is perfect.

I tested:

  • run calibration
  • load calibration (with and without microscope params in the calibration file)
  • offline mode QLIPP reconstruction (with and without microscope params in the calibration file)
    and all worked as expected.

Thanks for flagging the fact that the parameters will no longer be populated during "Load Calibration". I think the new behavior is correct.

@talonchandler talonchandler merged commit e932954 into 0.2.0-integration Oct 5, 2022
@ziw-liu ziw-liu deleted the rm-microscope-params branch October 5, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Microscope parameters" fields from calibration_metadata.txt
2 participants