Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block imageio versions that cause import error #228

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented Oct 7, 2022

Now napari installed by pip on Windows 10 will not run when one of some specific versions of imageio is fetched. This issue is somehow not causing a failure in our test-and-deploy checks.
For releasing 0.2.0 we will be matching napari's solution.

@ziw-liu ziw-liu added the bug Something isn't working label Oct 7, 2022
@ziw-liu ziw-liu added this to the 0.2.0 milestone Oct 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #228 (4b05f7a) into main (7cbda15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   10.03%   10.03%           
=======================================
  Files          40       40           
  Lines        5261     5261           
=======================================
  Hits          528      528           
  Misses       4733     4733           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/228
Created: 2022-10-07T00:13:47.082166

@ziw-liu ziw-liu marked this pull request as ready for review October 7, 2022 00:35
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Oct 7, 2022

Tested on Automaton (install, start, connect MM, calibration) and Hummingbird (install, start, connect).

@ziw-liu ziw-liu merged commit 6b4adbc into main Oct 7, 2022
@ziw-liu ziw-liu deleted the fix-imageio-import branch October 7, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants