Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify acquisition settings #246

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Simplify acquisition settings #246

merged 4 commits into from
Oct 28, 2022

Conversation

talonchandler
Copy link
Collaborator

Following our discussion in group meeting, I've made the following simplifying changes to the "Acquisition Settings" panel:

  • Instead of two 2D vs. 3D menus birefringence and phase, a single 2D vs. 3D menus
  • Renamed "Acq Channel (BF Only)" to "BF Channel"
  • "Phase from BF" checkbox aligned with "BF Channel" selection box

Screen Shot 2022-10-27 at 3 01 11 PM

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #246 (a682c99) into main (e9ab26c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #246      +/-   ##
========================================
+ Coverage   4.38%   4.40%   +0.01%     
========================================
  Files         22      22              
  Lines       4967    4953      -14     
========================================
  Hits         218     218              
+ Misses      4749    4735      -14     
Impacted Files Coverage Δ
recOrder/acq/acquisition_workers.py 0.00% <0.00%> (ø)
recOrder/plugin/gui.py 0.00% <0.00%> (ø)
recOrder/plugin/main_widget.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Oct 27, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/246
Updated: 2022-10-28T00:30:24.567285

Copy link
Contributor

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

Do you think there is a need to document what does 'Acquisition Mode' mean? It was not immediately clear to me from the GUI if the 2D and 3D modes for phase acquisition are capturing different raw data or doing different reconstruction.

@talonchandler
Copy link
Collaborator Author

Good call...I added a couple tooltips. Thanks @ziw-liu.

@talonchandler talonchandler merged commit e05974a into main Oct 28, 2022
@talonchandler talonchandler deleted the simplify-acq-settings branch October 28, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants