Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90 degree orientation offset checkbox #248

Merged
merged 3 commits into from
Nov 4, 2022
Merged

90 degree orientation offset checkbox #248

merged 3 commits into from
Nov 4, 2022

Conversation

talonchandler
Copy link
Collaborator

Thanks for offering to help finish and test this, Ziwen.

In this draft PR I've placed the GUI elements...the relevant checkbox is named cb_orientation_offset.

The expected behavior is:

  • unchecked by default...no change to to the reconstructions or visualization
  • if checked, both the reconstruction and the visualization of the reconstruction will be rotated by 90 degree---I think you'll like need to use apply something like pi/2 modulo pi to the existing reconstruction.

@talonchandler talonchandler added this to the 0.3.0 milestone Nov 1, 2022
@talonchandler talonchandler marked this pull request as draft November 1, 2022 00:27
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Nov 1, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/248
Updated: 2022-11-02T18:29:03.325948

@ziw-liu ziw-liu marked this pull request as ready for review November 2, 2022 21:32
@ziw-liu ziw-liu added the enhancement New feature or request label Nov 2, 2022
@talonchandler
Copy link
Collaborator Author

Just tested on hummingbird with Ed and it's working as I expect. Thanks for adding the warning message.

I can't approve a PR that I created, so can you approve and merge this, Ziwen? Thanks!

@ziw-liu
Copy link
Contributor

ziw-liu commented Nov 3, 2022

can you approve and merge this

Ideally there's some code review since I experienced some confusing behavior during local testing (most likely due to some cache issue with editable install, disappeared after rebooting the computer). Maybe @edyoshikun can take a look if you haven't already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we have an orientation offset field, and what should it look like?
2 participants