Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import qtpy instead of PyQt5 in autogenerated gui.py #252

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

talonchandler
Copy link
Collaborator

This fix requires "manually" changing the import in the autogenerated gui.py file, but I've made this as easy as possible by adding a sed one-liner to the developer documentation.

@talonchandler talonchandler added this to the 0.3.0 milestone Nov 4, 2022
@talonchandler talonchandler self-assigned this Nov 4, 2022
@ziw-liu
Copy link
Contributor

ziw-liu commented Nov 4, 2022

I just merged #233, introducing a conflict between this and HEAD. @talonchandler Can you take a look and resolve it?

@ziw-liu ziw-liu linked an issue Nov 4, 2022 that may be closed by this pull request
@ziw-liu ziw-liu added bug Something isn't working documentation Improvements or additions to documentation labels Nov 4, 2022
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Nov 4, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/252
Updated: 2022-11-04T17:35:28.252660

@talonchandler talonchandler merged commit 97fc4cf into main Nov 4, 2022
@talonchandler talonchandler deleted the PyQt5-to-qtpy branch November 4, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Package is using PyQt5 imports instead of qtpy
2 participants