Populate "BF Channel" list with presets containing keywords #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
========================================
- Coverage 4.38% 4.37% -0.01%
========================================
Files 22 22
Lines 4974 4979 +5
========================================
Hits 218 218
- Misses 4756 4761 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Preview page for your plugin is ready here: |
|
Another good keyword may be |
ieivanov
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the "BF Channel" list would be populated with all MM presets, which would lead to confusing defaults like this:
After this PR, the "BF Channel" list will only contain MM presets that have any of the following case-insensitive keywords as a substring:
["bf", "brightfield", "bright", "labelfree", "label-free", "lf", "label"]I checked these keywords against the latest MM configs on
CompMicro_MMConfigsand tested in person on hummingbird and falcon. Feel free to suggest/add other keywords.On hummingbird, the startup menus now look like this (similar on falcon):
