Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports into cli functions #317

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Move imports into cli functions #317

merged 2 commits into from
Feb 9, 2023

Conversation

talonchandler
Copy link
Collaborator

@talonchandler talonchandler commented Feb 8, 2023 •
edited
Loading

Fixes #315.

With this PR I can run recorder info and recorder convert without a screen.

@talonchandler talonchandler marked this pull request as ready for review February 8, 2023 22:44
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Feb 8, 2023 •
edited
Loading

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/317
Updated: 2023-02-08T22:50:39.944576

edyoshikun
edyoshikun approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I was able to run the converter and other functions that don't need the viewer in my local terminal and VScode SSH terminal.
Thank you again!

@talonchandler talonchandler merged commit a1451ee into main Feb 9, 2023
@edyoshikun edyoshikun deleted the import-inside-cli-funcs branch February 9, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyoshikun edyoshikun edyoshikun approved these changes

@ziw-liu ziw-liu Awaiting requested review from ziw-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recorder info fails when used without a screen
2 participants
@talonchandler @edyoshikun