Turn live mode off when loading calibration

[talonchandler]

Fixes #280

Tested on hummingbird

[codecov]

Codecov Report

Merging #335 (fbbd7c8) into main (add3280) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head fbbd7c8 differs from pull request most recent head 97df866. Consider uploading reports for the commit 97df866 to get more accurate results

@@           Coverage Diff            @@
##            main    #335      +/-   ##
========================================
- Coverage   2.06%   2.06%   -0.01%     
========================================
  Files         21      21              
  Lines       4888    4890       +2     
========================================
  Hits         101     101              
- Misses      4787    4789       +2     

Impacted Files	Coverage Δ
recOrder/plugin/main_widget.py	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[deprecated-napari-hub-preview-bot]

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/335
Created: 2023-04-10T23:09:29.294214

[ziw-liu]

To my eyes this is very similar to #282 but glad this worked! @talonchandler maybe also consider using that context manager?

[talonchandler]

It looks like we're using the context manager when we capture a background, and we're using these lines for running a calibration (where I got this from) and now for loading a calibration:

if self.calib.snap_manager.getIsLiveModeOn():
    self.calib.snap_manager.setLiveModeOn(False)

I agree that the context manager should do the same thing, so I don't understand why #282 isn't working.

Do you think it's worth the effort to test and understand this? Or do you think we should merge this fix and handle later?

[ziw-liu]

It seems like #282 didn't work because the load_calibration worker makes MMCore calls directly instead of reusing existing methods of the Calibration object. I can fix that.

[ziw-liu]

@talonchandler I'm fine with this PR either way since its just a few lines. It's your call whether we need this quick patch for the 0.3 release, but if you decide to merge maybe comment with FIXME in the code so that we don't forget about it.

[talonchandler]

Thanks for your flexibility @ziw-liu. I've added FIXME comments, and I'm looking forward to moving the MM calls off of the main thread later.