Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to single zarr store #340

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Write to single zarr store #340

merged 5 commits into from
Apr 13, 2023

Conversation

talonchandler
Copy link
Collaborator

Fixes #338.

Tested on all combinations of [Retardance + Orientation, Phase, Retardance + Orientation + Phase] and [2D, 3D]. All of the resulting zarrs can be drag-and-drop opened in napari with the recorder reader.

@talonchandler talonchandler added this to the 0.3.0 milestone Apr 12, 2023
@talonchandler talonchandler marked this pull request as ready for review April 12, 2023 23:00
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #340 (12bb5ed) into main (8c400d6) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #340   +/-   ##
=====================================
  Coverage   2.06%   2.06%           
=====================================
  Files         21      21           
  Lines       4893    4893           
=====================================
  Hits         101     101           
  Misses      4792    4792           
Impacted Files Coverage Δ
recOrder/acq/acquisition_workers.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Apr 12, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/340
Updated: 2023-04-13T00:58:58.821878

@talonchandler
Copy link
Collaborator Author

Just tested again on hummingbird. Thanks @ziw-liu!

@ziw-liu ziw-liu added the enhancement New feature or request label Apr 13, 2023
@talonchandler talonchandler added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit 190443a Apr 13, 2023
@ziw-liu ziw-liu deleted the save-to-one-zarr2 branch April 13, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One reconstructed zarr store per acquisition
2 participants