Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test docking the plugin widget #346

Merged
merged 16 commits into from
Jun 7, 2023
Merged

Test docking the plugin widget #346

merged 16 commits into from
Jun 7, 2023

Conversation

ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented Apr 21, 2023

Checks that the GUI can be initialized and docked to the napari viewer without throwing an error.

Signed-off-by: Ziwen Liu <67518483+ziw-liu@users.noreply.github.com>
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Apr 21, 2023

Already failing on GitHub CI!

Edit: The pytests workflow doesn't install X11 stuff. Since it's only a subset of test-and-deploy (linter is commented out) I've disabled it.

Also napari stable doesn't support python 3.11. The nightly build works but since there's no schedule for the next napari release I guess we should step down recOrder's support too...

@ziw-liu ziw-liu added the testing Testing the code label Apr 22, 2023
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Apr 22, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/346
Updated: 2023-05-03T21:13:18.881648

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #346 (8c7cfec) into main (802cc62) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##            main    #346      +/-   ##
========================================
+ Coverage   1.75%   1.95%   +0.20%     
========================================
  Files         20      21       +1     
  Lines       4841    4851      +10     
========================================
+ Hits          85      95      +10     
  Misses      4756    4756              
Impacted Files Coverage Δ
recOrder/acq/acquisition_workers.py 0.00% <ø> (ø)
recOrder/calib/calibration_workers.py 0.00% <ø> (ø)
recOrder/plugin/main_widget.py 0.00% <ø> (ø)
recOrder/tests/widget_tests/test_dock_widget.py 100.00% <100.00%> (ø)

@ziw-liu
Copy link
Contributor Author

ziw-liu commented May 3, 2023

Couldn't get Qt to work on the Linux runners. But Windows and macOS runs fine. I think as long as it tests on Windows (where the microscopes are) it's of some value.

@ziw-liu ziw-liu requested a review from talonchandler May 3, 2023 21:24
@ziw-liu ziw-liu marked this pull request as ready for review May 3, 2023 21:25
Copy link
Collaborator

@talonchandler talonchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this @ziw-liu.

@talonchandler talonchandler added this pull request to the merge queue Jun 7, 2023
Merged via the queue into main with commit 6b2b3cc Jun 7, 2023
@ziw-liu ziw-liu deleted the test-dock-widget branch June 8, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants