Skip QFileDialog.Options()
#404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
=====================================
Coverage 7.21% 7.21%
=====================================
Files 25 25
Lines 4438 4437 -1
=====================================
Hits 320 320
+ Misses 4118 4117 -1
|
|
Preview page for your plugin is ready here: |
ziw-liu
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403.
In PyQt5,
QFileDialoghas a class calledOptionsthat stores existing options.In PyQt6, this class seems to have disappeared, although
QFileDialog.Options()calls still appear further down the docs page (?).This two-line fix seems to have fixed the issue on hummingbird, where I tested the "Browse" buttons and "Load calibration".
We don't set options anywhere else, so I don't expect any changes to the previous behavior.