Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for PyQt5 #420

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Check for PyQt5 #420

merged 1 commit into from
Aug 19, 2023

Conversation

talonchandler
Copy link
Collaborator

Fixes #409.

I tried checking imports like @ziw-liu suggesting, but after pip uninstall PyQt5 I was still able to import PyQt5. The environment variable also failed.

I tested this solution on hummingbird.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #420 (e6c84af) into main (7f57e33) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #420      +/-   ##
========================================
- Coverage   8.30%   8.29%   -0.01%     
========================================
  Files         26      27       +1     
  Lines       4527    4532       +5     
========================================
  Hits         376     376              
- Misses      4151    4156       +5     
Files Changed Coverage Δ
recOrder/__init__.py 0.00% <0.00%> (ø)

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/420
Created: 2023-08-19T01:56:19.379133

Copy link
Contributor

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@talonchandler talonchandler added this pull request to the merge queue Aug 19, 2023
Merged via the queue into main with commit f1fedef Aug 19, 2023
8 of 10 checks passed
@talonchandler talonchandler deleted the check-pyqt5 branch September 24, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] If PyQt5 is in your environment, recOrder will use it (causing GUI checkboxes to fail)
2 participants