Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement schema #424

Merged
merged 44 commits into from
Aug 22, 2023
Merged

Implement schema #424

merged 44 commits into from
Aug 22, 2023

Conversation

talonchandler
Copy link
Collaborator

Implements the schema described in #421.

@ziw-liu my apologies the first three commits are from different branches...I can't seem to find the right branch to merge this to.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #424 (21f0320) into main (e17da56) will increase coverage by 0.25%.
Report is 1 commits behind head on main.
The diff coverage is 13.88%.

@@           Coverage Diff            @@
##            main    #424      +/-   ##
========================================
+ Coverage   8.40%   8.65%   +0.25%     
========================================
  Files         26      26              
  Lines       4475    4447      -28     
========================================
+ Hits         376     385       +9     
+ Misses      4099    4062      -37     
Files Changed Coverage Δ
recOrder/acq/acquisition_workers.py 0.00% <0.00%> (ø)
recOrder/calib/Calibration.py 0.00% <0.00%> (ø)
recOrder/calib/Optimization.py 0.00% <0.00%> (ø)
recOrder/calib/calibration_workers.py 0.00% <0.00%> (ø)
recOrder/io/utils.py 0.00% <0.00%> (ø)
recOrder/plugin/gui.py 0.00% <0.00%> (ø)
recOrder/plugin/main_widget.py 0.00% <0.00%> (ø)
recOrder/tests/util_tests/test_io.py 100.00% <100.00%> (ø)

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 21, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/424
Updated: 2023-08-22T00:23:47.009619

@ziw-liu
Copy link
Contributor

ziw-liu commented Aug 21, 2023

Why can't this target main?

@talonchandler talonchandler changed the base branch from nm-retardance to main August 21, 2023 23:48
@talonchandler
Copy link
Collaborator Author

Changed to target main. Sorry...when I started this branch nm_retardance hadn't merged, so I forgot to change it.

talonchandler and others added 2 commits August 21, 2023 17:13
Co-authored-by: Ziwen Liu <67518483+ziw-liu@users.noreply.github.com>
@talonchandler talonchandler added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 828f266 Aug 22, 2023
10 checks passed
@talonchandler talonchandler deleted the implement-schema branch September 24, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants