Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default HSV colormap #471

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Default HSV colormap #471

merged 4 commits into from
Jul 15, 2024

Conversation

talonchandler
Copy link
Collaborator

We typically expect HSV colormaps, so I'm changing the ret_ori_overlay function's default.

@edyoshikun related to: czbiohub-sf/shrimPy#141

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 11, 2024

Now that Qt is fixed, we have a new problem that PyTorch doesn't have a NumPy 2.0 compatible build on windows.

Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 11, 2024

Now that Qt is fixed, we have a new problem that PyTorch doesn't have a NumPy 2.0 compatible build on windows.

Nothing we can do about this one until upstream fixes their CD. Probably just pin numpy<2.0.0 for now.

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 12, 2024

Nothing we can do about this one until upstream fixes their CD. Probably just pin numpy<2.0.0 for now.

mehta-lab/waveorder#173

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 15, 2024

@talonchandler I think we should merge this since it has the napari fix.

@talonchandler talonchandler added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 7687259 Jul 15, 2024
5 of 10 checks passed
@ziw-liu ziw-liu deleted the better-overlay-default branch July 15, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants