Only allow exact id matches #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Laura Hausmann <laura@hausmann.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Strict AP object id check
The id property of the retrieved object must match the final redirect URL actually attempted.
https://akkoma.dev/AkkomaGang/akkoma/commit/8684964c5d03f6c70f73730b3f1ad26784ffb004
https://firefish.dev/firefish/firefish/-/merge_requests/10718/commits
多分、ドライブファイル等にAP Objectっぽいのを上げられた時にfakeオブジェクトが出来てしまう場合とかの受け側の対策。
現状のContent-Typeチェックである程度大丈夫な気はするけど、このチェックによってドライブファイル等アップロード後のURLが予測困難な場合攻撃が困難になるから多層防御として有効？