Add \t as recognized separator
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `\t` isn't seen as an recognized separator. This was causing issues for meilisearch, when it was trying to search on a keyword (fuzzy or exact match) and in the document the keyword was present but the character before the keyword was an `\t` charabia would create a token that was `\t<keyword>` which in turn led to meilisearch returning the document as part of the search but not returning the positions of matches (`_matchesPosition` field). The actual reproducer for this bug was code files of the Linux kernel (such as `fs/ext4/readpage.c`) which uses tabs for indentation and searching for keywords like `while` would usually be 'prefixed' by an tab causing the described issue. Making `\t` a separator fixed this issue.
ManyTheFish
approved these changes
Apr 16, 2024
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
\tisn't seen as an recognized separator. This was causing issues for meilisearch, when it was trying to search on a keyword (fuzzy or exact match) and in the document the keyword was present but the character before the keyword was an\tcharabia would create a token that was\t<keyword>which in turn led to meilisearch returning the document as part of the search but not returning the positions of matches (_matchesPositionfield).The actual reproducer for this bug was code files of the Linux kernel (such as
fs/ext4/readpage.c) which uses tabs for indentation and searching for keywords likewhilewould usually be 'prefixed' by an tab causing the described issue. Making\ta separator fixed this issue.