Replace jemalloc(ator) with mimalloc, which covers wider platforms #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tats-u
changed the title
tats-u
force-pushed
the
minimalize-jemalloc
branch
from
2ab9249 to
0ee5617
Compare
|
Hello @tats-u, sorry for the delay, can you use mimalloc instead? as you suggested in the issue? |
|
@ManyTheFish It works on Windows MSVC. |
tats-u
changed the title
|
Can I rebase this branch to main (not merge main into this branch) and squash my 2 commits into just one? |
ManyTheFish
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Hello @tats-u,
Github is able to rebase this kind of PR, so I did it with the UI,
Sorry for the delay and thank you for your work,
Bors merge
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #314
What does this PR do?
The platforms supported by jemallocator are limited. I use Windows but can't build charabia due to it. It should be disabled in unsupported platforms. It is used only for benchmarks.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!