Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify dependencies for python < 3.11 #316

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Specify dependencies for python < 3.11 #316

merged 1 commit into from
Jan 9, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #287

Will also fix the pylint upgrade issue in PR https://github.com/meilisearch/docs-scraper/actions/runs/3754861523/jobs/6379438841

What does this PR do?

  • Updates the Pipfile to specify needed dependencies for python < 3.11. These dependencies seem to only be needed by pytest or pylint` so I made them dev dependencies

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41 for this PR and for not forget about this repo ❤️

@alallema
Copy link
Contributor

alallema commented Jan 9, 2023

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jan 9, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 006ec06 into meilisearch:main Jan 9, 2023
@alallema alallema added the bug Something isn't working label Feb 6, 2023
@sanders41 sanders41 deleted the pipfile branch June 5, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the failing pytest version update
2 participants
@sanders41 @alallema