Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primary key can be changed if index is empty #1574

Closed
dichotommy opened this issue Apr 12, 2022 · 1 comment · Fixed by #1544 or #1597
Closed

primary key can be changed if index is empty #1574

dichotommy opened this issue Apr 12, 2022 · 1 comment · Fixed by #1544 or #1597

Comments

@dichotommy
Copy link
Contributor

dichotommy commented Apr 12, 2022 •
edited
Loading

As discussed in this slack message (private link) and this PR comment, it is now possible to change the primary key of an empty index using the update index endpoint.

Before, you could only do this if the index had never possessed a primary key.

I'm not sure which pages are affected by this change, but certainly the update index endpoint (linked above) could be clarified, and possibly also the primary key guide.
@dichotommy dichotommy mentioned this issue Apr 12, 2022
Merged
@curquiza
Copy link
Member

FYI there is the fresh new spec defining the behavior here: https://github.com/meilisearch/specifications/blob/develop/text/0132-indexes-api.md#324-put---indexesindex_uid

@gmourier FYI

@maryamsulemani97 maryamsulemani97 linked a pull request Apr 13, 2022 that will close this issue
Primary key guide #1544
Merged
@maryamsulemani97 maryamsulemani97 mentioned this issue Apr 13, 2022
Merged
@bors bors bot closed this as completed in #1544 Apr 26, 2022
bors bot added a commit that referenced this issue Apr 28, 2022
@bors @maryamsulemani97
Merge #1597
7568a02 
1597: primary key can be changed if index is empty r=maryamsulemani97 a=maryamsulemani97

closes #1574

Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@curquiza @dichotommy