Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: API endpoint verbs update #1732

Merged
merged 3 commits into from
Jun 30, 2022
Merged

v0.28: API endpoint verbs update #1732

merged 3 commits into from
Jun 30, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1702

@maryamsulemani97 maryamsulemani97 added this to the v0.28 milestone Jun 16, 2022
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review June 16, 2022 14:24
guimachiavelli
guimachiavelli reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it me being blind or are we missing the verb update on the update an index endpoint?

I'm talking about this one:

  • PUT -> PATCH /indexes/{indexUid}

@maryamsulemani97
Copy link
Contributor Author

Yes, it's missing. Thanks Gui!

@guimachiavelli guimachiavelli linked an issue Jun 23, 2022 that may be closed by this pull request
v0.28: API endpoint verbs update #1702
Closed
@guimachiavelli
Copy link
Member

Oops, found another missing update: code sample geosearch_guide_filter_settings_1

guimachiavelli
guimachiavelli approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏞️

@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
Closed
17 tasks
@guimachiavelli
Copy link
Member

bors merge

@bors bors bot merged commit 4a53358 into v0.28 Jun 30, 2022
@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

Build succeeded:

@bors bors bot deleted the v0.28--API-endpoint-verbs-update branch June 30, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@dichotommy dichotommy Awaiting requested review from dichotommy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.

v0.28: API endpoint verbs update
2 participants
@maryamsulemani97 @guimachiavelli