Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep info on phrase/placeholder search in a single place #2650

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Keep info on phrase/placeholder search in a single place #2650

merged 2 commits into from
Dec 15, 2023

Conversation

guimachiavelli
Copy link
Member

Fixes #2544

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:better-phrase-search-navigation

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review December 13, 2023 18:38
curquiza
curquiza approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you gui

@curquiza curquiza merged commit b23a165 into main Dec 15, 2023
1 check passed
@curquiza curquiza deleted the better-phrase-search-navigation branch December 15, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phrase search concept link
3 participants
@guimachiavelli @meili-bot @curquiza