-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js multitenancy guide #2704
Conversation
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:add-nodejs-multitenancy-guide Credentials to access the page are in the company's password manager as "Docs deploy preview". |
Honestly, I don't think this guide adds anything to the documentation. What we explain here is basically the same as what's in the dedicated section of the documentation. I think it could be a bit longer and add something different, like explaining how to connect the back end and front end. |
Thanks for the feedback @CaroFG, I'll see how I can revisit this. |
--------- Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
I've updated the guide. I think this is ready for review @CaroFG @guimachiavelli. |
Co-authored-by: CaroFG <48251481+CaroFG@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things, mostly suggestions to cut things that might not be necessary.
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Thanks for the review @guimachiavelli 🙏 I applied most suggestions and fixed conflicts. All green to merge on my end 👌 |
Looks good to go for me. I see @CaroFG had a few comments, so I'll wait for her ok before merging |
LGTM! |
reviewer gave final ok after changes
Pull Request
Related issue
Fixes #2703
What does this PR do?
This PR repurposes the instructions from this Multi-tenancy guide to create a guide focusing on implementing multi-tenancy with Nodejs.
To be completely honest, I'm a bit hesitant about the value this adds compared to the tenant tokens docs, so feedback is welcome @guimachiavelli @CaroFG
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!