Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit from queries #2962

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

CaroFG
Copy link
Contributor

@CaroFG CaroFG commented Aug 28, 2024

Pull Request

Related issue

Fixes #2961

What does this PR do?

  • Removes limit search parameter from queries in federated multi-search code sample

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@CaroFG CaroFG requested a review from a team as a code owner August 28, 2024 11:41
@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:correct-multi-search-federated-code-sample

Credentials to access the page are in the company's password manager as "Docs deploy preview".

Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks you

@Kerollmops Kerollmops merged commit 6c1cd33 into main Aug 28, 2024
1 check passed
@Kerollmops Kerollmops deleted the correct-multi-search-federated-code-sample branch August 28, 2024 11:59
meili-bors bot added a commit to meilisearch/meilisearch-php that referenced this pull request Sep 19, 2024
680: Fix code samples r=curquiza a=curquiza

following meilisearch/documentation#2962

Co-authored-by: Clémentine <clementine@meilisearch.com>
meili-bors bot added a commit to meilisearch/meilisearch-js that referenced this pull request Sep 21, 2024
1712: Fix code samples r=flevi29 a=curquiza

Following meilisearch/documentation#2962

Co-authored-by: Clémentine <clementine@meilisearch.com>
Co-authored-by: F. Levi <55688616+flevi29@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect code sample for federated multi-search
4 participants