-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the PATCH /embedders path on update_embedders_1 #3099
Use the PATCH /embedders path on update_embedders_1 #3099
Conversation
Hmmm…for some reason GH is not able to run that action, even though all your previous PRs had no issues. Making the same changes in another PR works, so I'm not sure what is causing the GH action to fail. I'll take a look at this again tomorrow, in case it's a temporary fluke on GitHub's side. |
I don't think any checks ran on my previous PRs, since this is the first PR after you merged my first PR. Technically before this PR you would have to approve running checks since I was a stranger to this repo. It looks to me that the action is broken generally. |
Seems to also be broken on #3102
|
Yeah, I think you're right, but at the moment it's very unclear what exactly is broken. I'm guessing something related to the API token we're using and permissions, since the action seems to be failing only for contributors outside the meilisearch org. I'll continue looking into it and hopefully merge this PR soon. |
Instead of keeping this on a limbo until we sort out whatever is happening with the repo's workflows, I'm going to bypass the requirements. The content of the PR looks good and the only relevant action automates something I can do manually. Thanks for another useful contribution, @ellnix! |
Pull Request
Related issue
Fixes #3096