Skip to content

Commit

Permalink
Merge #179
Browse files Browse the repository at this point in the history
179: Update nodejs runtime to node20 r=curquiza a=brunoocasali

Fixes #178

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
  • Loading branch information
meili-bors[bot] and brunoocasali authored May 22, 2024
2 parents fda0218 + d7678ce commit 28b9e9a
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 24 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/beta-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16', '18']
node: ['20']
name: integration-tests (Node.js ${{ matrix.node }})
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pre-release-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16', '18']
node: ['20']
name: integration-tests (Node.js ${{ matrix.node }})
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
publish-npm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/
- name: Check release validity
run: sh .github/scripts/check-release.sh
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16', '18']
node: ['20']
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
Expand All @@ -33,11 +33,11 @@ jobs:
runs-on: ubuntu-latest
name: style-check
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- name: Install dependencies
run: yarn install:functions
- name: Run style check
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ First of all, thank you for contributing to Meilisearch! The goal of this docume

To run this project, you will need:

- Node >= 14 && node <= 18
- Node >= 20
- Npm >= v7
- A google account
- Version `v10.9.2` of `firebase-tools` the Firebase CLI (latest does not provide the emulator):
Expand Down
7 changes: 1 addition & 6 deletions bors.toml
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
status = [
'style-check',
'integration-tests (14)',
'integration-tests (16)',
'integration-tests (18)'
]
status = ['style-check', 'integration-tests (20)']
# 1 hour timeout
timeout-sec = 3600
2 changes: 1 addition & 1 deletion extension.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ resources:
# LOCATION is a user-configured parameter value specified by the user
# during installation.
location: ${LOCATION}
runtime: nodejs14
runtime: nodejs20
eventTrigger:
eventType: providers/cloud.firestore/eventTypes/document.write
resource: projects/${PROJECT_ID}/databases/(default)/documents/${COLLECTION_PATH}/{documentID}
Expand Down
2 changes: 1 addition & 1 deletion functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"test:coverage": "jest --coverage"
},
"engines": {
"node": ">=14.0.0"
"node": ">=20.0.0"
},
"main": "lib/index.js",
"dependencies": {
Expand Down

0 comments on commit 28b9e9a

Please sign in to comment.