Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass firebase client agent to meilisearch-js #91

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

bidoubiwa
Copy link
Contributor

See related issue

This PR passes down the information of the firebase plugin package to the meilisearch-js package which in turn provided the information to meilisearch.

@bidoubiwa bidoubiwa added the enhancement New feature or request label Jul 11, 2022
@bidoubiwa bidoubiwa changed the title Pass firebase client agent to meilisearch=js Pass firebase client agent to meilisearch-js Jul 11, 2022
@bidoubiwa bidoubiwa removed the request for review from brunoocasali July 11, 2022 10:27
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

Base automatically changed from update_meilisearch_js_to_0.27.0-beta.1 to bump-meilisearch-v0.28.0 July 11, 2022 12:00
@bidoubiwa bidoubiwa merged commit 8448006 into bump-meilisearch-v0.28.0 Jul 11, 2022
@bidoubiwa bidoubiwa deleted the add_user_agent_in_client branch July 11, 2022 12:00
meili-bors bot added a commit that referenced this pull request Jul 12, 2022
92: Update version for the next release (v0.1.5) r=bidoubiwa a=bidoubiwa

Content of the release:

This version makes this package compatible with Meilisearch v0.28.0 🎉
Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes.

## 🚀 Enhancements

- #91 

Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection)
Also, of course, every analytics data we collect are ANONYMOUS [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html).

Thanks again to `@bidoubiwa` ! 🎉

Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants