add custom ordering support to range types #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Thank you very much for those changes!
I love seeing this kind of PR fixing hidden bugs like that.
As this is breaking, I'll probably release this PR as part of a new version later when #278 lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds custom ordering support to the
iterator/rangetypes, by using theComparatortrait. Without this PR using any of therangefunctions onDatabasewhen a custom ordering is set will give unexpected results, like not giving all the keys in the range.This PR also adds a
IntegerComparatortype, which represents the ordering when theMDB_INTEGERKEYflag is set. This is needed to allow the range functions to work when a table sets that flag.