Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting NDEBUG on release builds #324

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Setting NDEBUG on release builds #324

merged 1 commit into from
Mar 10, 2025

Conversation

Kerollmops
Copy link
Member

When building LMDB in non-debug (release) it should set the NDEBUG env variable so that LMDB is compiled in non-debug. We should see perf improvements. Fixes #322.

@Kerollmops Kerollmops added this to the v0.22.0 🔑 milestone Mar 10, 2025
@Kerollmops Kerollmops requested a review from dureuill March 10, 2025 12:52
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kerollmops Kerollmops enabled auto-merge March 10, 2025 15:29
@Kerollmops Kerollmops disabled auto-merge March 10, 2025 15:29
@Kerollmops Kerollmops enabled auto-merge March 10, 2025 15:29
@Kerollmops Kerollmops merged commit 14637cb into main Mar 10, 2025
18 checks passed
@Kerollmops Kerollmops deleted the ndebug-in-release branch March 10, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set NDEBUG in non-debug builds
2 participants