Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix linting issues #403

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Chore: fix linting issues #403

merged 2 commits into from
Jan 10, 2025

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Jan 10, 2025

Pull Request

Fixes linting issues blocking #402

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 10, 2025
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jan 10, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit fef2c54 into main Jan 10, 2025
6 checks passed
@meili-bors meili-bors bot deleted the chore/fix-linting-issues branch January 10, 2025 10:36
Copy link
Collaborator

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there are a lot of unnecessary changes in this pr
especially in pubspec.yaml

@curquiza
Copy link
Member

Sorry @ahmednfwela I wanted to be fast. Feel free to open a new one, I will review and merge it as soon as possible, that's my bad here

@ahmednfwela
Copy link
Collaborator

that's fine @curquiza but can you revert the changes? they contain lots of breaking changes

@curquiza
Copy link
Member

Ok I revert the PR

meili-bors bot added a commit that referenced this pull request Jan 10, 2025
405: Revert "Chore: fix linting issues" r=ahmednfwela a=curquiza

Reverts #403

Co-authored-by: Clémentine <clementine@meilisearch.com>
Co-authored-by: ahmednfwela <afwela@inpro.sa>
meili-bors bot added a commit that referenced this pull request Feb 18, 2025
411: Update version for the next release (v0.17) r=Strift a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-dart to a new version: "v0.17"

👇 CHANGELOG

## ✨ New

* [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search) is now stable `@/Strift`

## 🚀 Enhancements

* implement experimental ai-powered search (#398) `@/memishood`
* Rename current_mean and current_sigma for AI feature (#407) `@/ahmednfwela`
* Stabilize vector store usage (#410) `@/Strift`
* Changes related to the next Meilisearch release (v1.13) (#408) `@/Strift`

## ⚙️ Maintenance/misc

* Chore: fix linting issues (#403) `@/Strift`
* Revert "Chore: fix linting issues" & fix linting (#405) `@/curquiza`

Thanks again to `@/Strift,` `@/ahmednfwela,` `@/curquiza,` `@/meili-bors[bot],` and `@memishood!` 🎉



Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Laurent Cazanove <lau.cazanove@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants