-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rank threshold #582
Merged
meili-bors
merged 11 commits into
meilisearch:main
from
danFbach:add-rank-threshold-544
Nov 27, 2024
Merged
Add rank threshold #582
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
93379e2
fixed spacing. added index set up for testing RankingScoreThreshold
danFbach 1e49c13
added missing space
danFbach 4631441
added CustomSearchWithRankingScoreThreshold test.
danFbach 3e58dfe
added property RankingScoreThreshold for setting rankingScoreThreshol…
danFbach d5e7a9f
Added code sample for utilizing RankingScoreThreshold property
danFbach 77a0784
c# code sample more accurately reflects curl example
danFbach 9a5328d
new line for linter
danFbach 708fced
Merge branch 'main' into add-rank-threshold-544
danFbach 4d9cc53
Merge branch 'main' into add-rank-threshold-544
danFbach 7cff6dd
Update .code-samples.meilisearch.yaml
curquiza 80eea39
new line, remove trailing whitespace
danFbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -782,3 +782,9 @@ distinct_attribute_guide_distinct_parameter_1: |- | |
Distinct = "sku" | ||
}; | ||
await client.Index("products").SearchAsync<Product>("white shirt", params); | ||
search_parameter_reference_ranking_score_threshold_1: |- | ||
var params = new SearchQuery() | ||
{ | ||
RankingScoreThreshold = 0.2M | ||
}; | ||
await client.Index("INDEX_NAME").SearchAsync<T>("badman", params); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove the "no new line" at the end of the line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we follow the editorconfig rules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 0.2M? and not
0.2
, cf https://github.com/meilisearch/documentation/blob/04f26a35771305378ed0a506f4d60ef06d07bd7e/.code-samples.meilisearch.yaml#L1350There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c# requires

M
when setting a decimal value.0.2
is interpreted as adouble
and0.2M
is adecimal
.ex: